Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectangular connections to WEIS #58

Merged
merged 6 commits into from
Jul 13, 2024
Merged

Rectangular connections to WEIS #58

merged 6 commits into from
Jul 13, 2024

Conversation

dzalkind
Copy link
Contributor

@dzalkind dzalkind commented Jul 12, 2024 •
edited
Loading

Purpose

Cherry-picking @yqliaohk 's openmdao updates in #51 and pointing to master, so we can use these connections in WEIS.

I removed the VolturnUS rect test case and merged it into a single test case generated by the WEIS example: https://github.com/WISDEM/WEIS/blob/develop/examples/15_RAFT_Studies/weis_driver_raft_opt.py

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind
Copy link
Contributor Author

@yqliaohk, @lucas-carmo, does this require anything in dev or can it be merged into master?

@lucas-carmo
Copy link
Contributor

@dzalkind I took a look at the changed files and couldn't identify anything that would require dev. What do you think, @yqliaohk?

@gbarter gbarter merged commit 94d1953 into master Jul 13, 2024
14 checks passed
@gbarter gbarter deleted the omdao_rect branch July 13, 2024 14:23
@yqliaohk
Copy link
Contributor

@dzalkind I took a look at the changed files and couldn't identify anything that would require dev. What do you think, @yqliaohk?

@dzalkind @lucas-carmo @gbarter
Sorry for the late response! There are some bug fixes on the rectangular member related calculations that are only in dev branch right now (https://github.com/WISDEM/RAFT/commits/dev/?before=9b0509974150342cbef2e7d4a3eecc326ed84a32+105) , but it should be able to run with master to create rectangular members.

@lucas-carmo
Copy link
Contributor

You're right, I forgot about that bug fix!
As far as I remember, it fixes the hydrostatics of surface piercing rectangular elements. But it's not a huge change, I would say it's only relevant for a rectangular spar. For semisubs with rectangular columns, hydrostatics would be very slightly off (depending on the distance between columns). For semisubs with rectangular pontoons, that bug fix has no impact whatsoever.

I think this PR is safe to be merged.

@mattEhall
Copy link
Contributor

I agree, good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzalkind @lucas-carmo @yqliaohk @mattEhall @gbarter